Fix for unicode issue with ConsoleRunner#1
Open
adamlehenbauer wants to merge 1 commit intojline:masterfrom
Open
Fix for unicode issue with ConsoleRunner#1adamlehenbauer wants to merge 1 commit intojline:masterfrom
adamlehenbauer wants to merge 1 commit intojline:masterfrom
Conversation
….net/tracker/?func=detail&aid=3293355&group_id=64033&atid=506056, feeds bytes to higher-level InputStream instead of chars
Contributor
|
I was hoping this would fix non-ASCII characters on Macs with a german keyboard. It doesn't - I still get umlauts read and echoed as "?". Any idea about the cause/fix for that problem? |
Author
|
This is probably because I just used String#getBytes(), which will use the 'platform default' encoding, which appears to be the 'file.encoding' system property, or UTF-8. I would throw in a System.out.println(sline) around line 94 to ensure that the string is intact there, and then see if specifying an encoding in String#getBytes() fixes it. I think jline could try to pass around the encodings it pulls in, but those aren't consistent; UnixTerminal uses 'input.encoding' but ConsoleReader uses 'file.encoding'... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simple fix for multi-byte unicode character issue https://sourceforge.net/tracker/?func=detail&aid=3293355&group_id=64033&atid=506056, feeds bytes to higher-level InputStream instead of chars
this is my attempted fix, I've done basic tests with ConsoleRunner and another application that uses ConsoleReader